[Containerapp] az containerapp arc: Enable setup custom core dns for Openshift#8858
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp arc setup-core-dns | cmd containerapp arc setup-core-dns update parameter distro: updated property choices from ['AksAzureLocal'] to ['AksAzureLocal', 'openshift'] |
|
Hi @anandgmenon, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
jsntcy,
ruslany,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom CoreDNS setup for OpenShift clusters alongside the existing AKS support.
- Adds OpenShift-specific constants and logic to create and patch CoreDNS resources.
- Introduces new functions in _arc_utils.py for managing deployments, config maps, and DNS operator configurations on OpenShift.
- Updates CLI parameter definitions to include OpenShift as a supported distro.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/containerapp/azext_containerapp/custom.py | Adds OpenShift branch in setup_core_dns and related logging/error handling. |
| src/containerapp/azext_containerapp/_params.py | Updates CLI argument to include OpenShift distro with a minor typo in the help text. |
| src/containerapp/azext_containerapp/_constants.py | Introduces new constants for OpenShift support. |
| src/containerapp/azext_containerapp/_arc_utils.py | Adds multiple helper functions for creating/updating resources and patching DNS operator for OpenShift. |
Comments suppressed due to low confidence (1)
src/containerapp/azext_containerapp/_arc_utils.py:637
- [nitpick] The error message appears counterintuitive; consider rephrasing it to indicate that the required key is missing (e.g., "'k4apps-default.io.server' key not found in the coredns-custom ConfigMap in kube-system namespace.").
raise ValidationError("'k4apps-default.io.server' key found in the coredns-custom ConfigMap in kube-system namespace.")
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Please also update history.rst with releasee note for the feature. In addition, do you want to release the feature? If yes, please update version in setup.py |
zhoxing-ms
changed the title
az containerapp arc: Enable setup custom core dns for Openshift
|
Could you please add some test cases for these PR changes? |
These changes are specifically targeted for container apps on arc for openshift cluster. Hence adding testcases for the same will need a openshift cluster which can be tricky. Wondering if we can skip them here |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/msazure/One/_build/results?buildId=130273726&view=results |
… Openshift on Arc
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.